amccarth abandoned this revision.
amccarth added a comment.
I create a new review thread for my improved patch shortly. These changes were
too wide-ranging.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68953/new/
https://reviews.llvm.org/D68953
amccarth marked 2 inline comments as done.
amccarth added a comment.
Somehow Phabricator failed to notify me that you'd already left comments. I
even searched my inbox to see if I'd just missed the notification. Nope.
Nothing. I came here today to ping you for the review and discovered you'd
rnk added subscribers: arphaman, vsapsai, Bigcheese.
rnk added a comment.
+VFS people, mostly just to let them know
@arphaman @Bigcheese @vsapsai
Code changes all look good to me, but I had a bunch of questions.
Comment at: clang/lib/Lex/HeaderSearch.cpp:782-783
// Conc
amccarth created this revision.
amccarth added a reviewer: rnk.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
Inconsistencies in when/if paths are cannoicalized prevented VFS tests from
working on Windows. This fixes the primary cause and enables most of the te
