[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

mgorny added a comment. In D68927#1709395 , @sylvestre.ledru wrote: > In that function > https://github.com/llvm/llvm-project/blob/5fd467feb813eefe3558da434cb038213582/clang/cmake/modules/AddClang.cmake#L180 I'm not really sure what you mean me to

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

sylvestre.ledru added a comment. In that function https://github.com/llvm/llvm-project/blob/5fd467feb813eefe3558da434cb038213582/clang/cmake/modules/AddClang.cmake#L180 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68927/new/ https://reviews.l

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c9bd1657cbd: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

mgorny added a comment. Sure but what doc? The non-existing one of `clang_target_link_libraries`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68927/new/ https://reviews.llvm.org/D68927 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Thanks It fixed my problem. Maybe you could improve the doc and/or comment to make this behavior more explicit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68927/

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

mgorny created this revision. mgorny added reviewers: sylvestre.ledru, beanz. Fix accidentally making clangTidy library link to dylib. This causes libclang.so to also link to dylib which results in duplicate symbols from shared and static libraries, and effectively to registering command-line opt