compositeprimes marked 3 inline comments as done.
compositeprimes added a comment.
Sorry for the delay; I got caught up in some other work.
I moved this to https://reviews.llvm.org/D69782 using arc diff.
@gribozavr: I'm not sure how to merge this with the other commit, because it's
in clang-tid
alexfh added inline comments.
Comment at: include/clang/Tooling/Core/Diagnostic.h:93
+ /// representation of the source code associated with the diagnostic.
+ ArrayRef Ranges;
};
Please add YAML serialization/deserialization code for this. See
include/clang/T
gribozavr added a comment.
Please upload patches with context in future (`arc diff` will do that for you).
Please also merge this patch with the user, https://reviews.llvm.org/D68887. No
need to add untested code.
Comment at: include/clang/Tooling/Core/Diagnostic.h:88
+
+
+
compositeprimes created this revision.
compositeprimes added reviewers: clang, clang-tools-extra.
compositeprimes added projects: clang, clang-tools-extra.
Herald added a subscriber: cfe-commits.
Part 1 of the change:
The goal is instead of dropping all the ranges associated with a Diagnostic
whe
