This revision was automatically updated to reflect the committed changes.
Closed by commit rG885c559369fe: [ClangTidy] Separate tests for infrastructure
and checkers (authored by gribozavr).
Changed prior to commit:
https://reviews.llvm.org/D68807?vs=224378&id=224569#toc
Repository:
rG LLVM
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
I agree that the test/clang-tidy directory has become hard to navigate.
Splitting tests for checks and for infrastructure seems reasonable to me. I
personally don't care about specific directo
gribozavr added a comment.
It would look weird if we have a ton of tests for checkers in a directory, and
then a subdirectory for infra tests.
Why are we trying to optimize the number of renamed files? I already did the
renaming, so we are not saving any work. I think we should optimize for
lo
lebedev.ri added a comment.
Description says:
> making it easier to find infrastructure tests
> Tests for infrastructure were difficult to find because they were
> outnumbered by tests for checkers.
So presumably there far fewer infra tests as compared to checker tests,
and the issue is specif
gribozavr added a comment.
Why does the number of moves matter? Git preserves history across moves.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68807/new/
https://reviews.llvm.org/D68807
___
cfe-comm
lebedev.ri added a comment.
That's a lot of moved files.
How about *only* moving the infrastructure tests?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68807/new/
https://reviews.llvm.org/D68807
___
c
gribozavr created this revision.
Herald added subscribers: cfe-commits, lebedev.ri, jfb, arphaman, mgrang,
christof, kbarton, aheejin, nemanjai, srhines.
Herald added a reviewer: jfb.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: lebedev.ri.
Herald added a project: clang.
gribozavr
