This revision was automatically updated to reflect the committed changes.
Closed by commit rGc1f8e04eeefe: [CUDA][HIP} Add a test for constexpr default
ctor (authored by yaxunl).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D68753?vs=224492&id=224529#toc
Rep
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Sometimes I wish it would be possible to specify some of the -verify
diagnostics in temporal order, as opposed to tying them to locations. I.e. in
this case it would be way more useful to see
yaxunl updated this revision to Diff 224492.
yaxunl marked an inline comment as done.
yaxunl added a comment.
revised by Artem's comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68753/new/
https://reviews.llvm.org/D68753
Files:
test/SemaCUDA/constexpr-ctor.cu
Index: test/Sema
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: test/SemaCUDA/constexpr-ctor.cu:14-27
+template struct B {
+ T a;
+ constexpr B() = default;
+};
+
+template struct C {
+ T a;
tra wrote:
> yaxunl wrote:
> > tra wrote:
> > >
tra added inline comments.
Comment at: test/SemaCUDA/constexpr-ctor.cu:14-27
+template struct B {
+ T a;
+ constexpr B() = default;
+};
+
+template struct C {
+ T a;
yaxunl wrote:
> tra wrote:
> > Do we really need three identical templates? If they are need
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: test/SemaCUDA/constexpr-ctor.cu:14-27
+template struct B {
+ T a;
+ constexpr B() = default;
+};
+
+template struct C {
+ T a;
tra wrote:
> Do we really need three identical t
tra added inline comments.
Comment at: test/SemaCUDA/constexpr-ctor.cu:14-27
+template struct B {
+ T a;
+ constexpr B() = default;
+};
+
+template struct C {
+ T a;
Do we really need three identical templates? If they are needed to let compiler
emit multip
yaxunl created this revision.
yaxunl added a reviewer: tra.
https://reviews.llvm.org/D68753
Files:
test/SemaCUDA/constexpr-ctor.cu
Index: test/SemaCUDA/constexpr-ctor.cu
===
--- /dev/null
+++ test/SemaCUDA/constexpr-ctor.cu
@@ -0
