[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd18e94697c9: [mangle] Fix mangling where an extra mangle context is required. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68715/new/

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

hliao added a comment. In D68715#1701986 , @efriedma wrote: > LGTM Thanks. BTW, shall I commit the refactoring code directly. That change just replaces the code returning multiple values from pointer/reference argument with a tuple. Repository: rG

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68715/new/ https://reviews.llvm.org/D68715 ___

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

hliao added a comment. s/code/core/ in last comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68715/new/ https://reviews.llvm.org/D68715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:353 + ManglingContextDecl), +ManglingContextDecl); } efriedma wrote: > If I'm following correctly, t

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

hliao updated this revision to Diff 224115. hliao added a comment. remove refactoring code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68715/new/ https://reviews.llvm.org/D68715 Files: clang/include/clang/AST/ASTContext.h clang/include/clang

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

efriedma added a comment. The refactoring of the getCurrentMangleNumberContext API mixed with functional changes makes this much harder to review quickly. Please separate it out. Comment at: clang/lib/Sema/SemaLambda.cpp:353 + Mangling

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

hliao created this revision. hliao added reviewers: rsmith, eli.friedman. Herald added a project: clang. Herald added a subscriber: cfe-commits. - [Itanium C++ ABI][1], for certain contexts like default parameter and etc., mangling numbering will be local to the particular argument in which it ap