[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

2019-10-09 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr added a reviewer: gribozavr. gribozavr requested changes to this revision. gribozavr added a comment. This revision now requires changes to proceed. +1 to what MyDeveloperDay said. The infrastructure can't know whether the newlines are intentional or not. Checks that edit the source cod

[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

2019-10-09 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Sorry, I'm going to give a drive-by comment (which you can ignore), mainly by because you mentioned `clang-format`. This seems like a good idea as obviously it solves this problem, however, isn't rather like trying to fix it after the fact? what if (I'm sure the

[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

2019-10-08 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. You may be iinterested to l Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68682/new/ https://reviews.llvm.org/D68682 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

2019-10-08 Thread Conrad Poelman via Phabricator via cfe-commits
poelmanc created this revision. poelmanc added reviewers: jonathanmeier, alexfh. poelmanc added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, ormris. Herald added a project: clang. Clang-tidy can ignore most formatting concerns as formatting is clang-format's job. H