[PATCH] D68665: [HIP] Fix -save-temps

2019-10-09 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. yaxunl marked 4 inline comments as done. Closed by commit rGbc2350a34126: [HIP] Fix -save-temps (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D68665?vs=223944&id=224

[PATCH] D68665: [HIP] Fix -save-temps

2019-10-09 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68665/new/ https://reviews.llvm.org/D68665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D68665: [HIP] Fix -save-temps

2019-10-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 8 inline comments as done. yaxunl added inline comments. Comment at: lib/Driver/Driver.cpp:4400 + // HIP image for device compilation with -fno-gpu-rdc is per compilation + // unit. + bool IsHIPNoRDC = JA.getOffloadingDeviceKind() == Action::OFK_HIP &

[PATCH] D68665: [HIP] Fix -save-temps

2019-10-08 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/Driver.cpp:4400 + // HIP image for device compilation with -fno-gpu-rdc is per compilation + // unit. + bool IsHIPNoRDC = JA.getOffloading

[PATCH] D68665: [HIP] Fix -save-temps

2019-10-08 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Currently clang does not save some of the intermediate file generated during device compilation for HIP when -save-temps is specified. This patch fixes that. https://reviews.llvm.org/D68665 Files: lib/Driver/Driver.cpp lib/