[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao added a comment. In D68660#1705087 , @thakis wrote: > This makes tests assert on Mac: http://45.33.8.238/mac/1415/step_6.txt please let me know whether that works for you. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao added a comment. In D68660#1705087 , @thakis wrote: > This makes tests assert on Mac: http://45.33.8.238/mac/1415/step_6.txt I have no access to MacOS but try to fix that in r374478. Maybe that's a good excuse for a MacBook, ;) Repository: rG

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

thakis added a comment. This makes tests assert on Mac: http://45.33.8.238/mac/1415/step_6.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68660/new/ https://reviews.llvm.org/D68660 ___ cfe-commits m

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ccb39bbd87c: [tooling] Teach Tooling to understand compilation with offloading. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68660/new

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao updated this revision to Diff 224476. hliao marked an inline comment as done. hliao added a comment. revice comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68660/new/ https://reviews.llvm.org/D68660 Files: clang/lib/Tooling/Tooling.

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:102 + if (isa(A)) { +assert(Actions.size() == 2); +assert(isa(Actions.front())); tra wrote: > Why 2? Will it not be different if us

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

tra added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:102 + if (isa(A)) { +assert(Actions.size() == 2); +assert(isa(Actions.front())); Why 2? Will it not be different if user targeted multiple GPUs? Comment

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { -

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao updated this revision to Diff 224443. hliao added a comment. add more assertions on offload compilation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68660/new/ https://reviews.llvm.org/D68660 Files: clang/lib/Tooling/Tooling.cpp clang/

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

klimek added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { tra wrote: > hliao wrote: >

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

tra added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { hliao wrote: > tra wrote: > >

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { -

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

tra added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { hliao wrote: > tra wrote: > >

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68660/new/ https://reviews.llvm.org/D68660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { -

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

tra added a reviewer: klimek. tra added a comment. Added Manuel as someone familiar with tooling. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator()

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - So far, we only recognize the compilation with offloading and skip the offloading part. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D6866