ymandel marked 2 inline comments as done.
ymandel added inline comments.
Comment at: clang/lib/Tooling/Transformer/CMakeLists.txt:3
+
+add_clang_library(clangTransformer
+ RangeSelector.cpp
thakis wrote:
> All the other libs in lib/Tooling/Foo are called clangTo
thakis added inline comments.
Comment at: clang/lib/Tooling/Transformer/CMakeLists.txt:3
+
+add_clang_library(clangTransformer
+ RangeSelector.cpp
All the other libs in lib/Tooling/Foo are called clangToolingFoo, not clangFoo.
Can you please rename this library
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfbdf83521b17: [libTooling] Move Transformer files to their
own directory/library. (authored by ymandel).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68637/
ymandel updated this revision to Diff 223856.
ymandel added a comment.
update another cmakelists file (uncovered by linking for shared libs)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68637/new/
https://reviews.llvm.org/D68637
Files:
clang-to
ymandel updated this revision to Diff 223840.
ymandel added a comment.
update header guards
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68637/new/
https://reviews.llvm.org/D68637
Files:
clang-tools-extra/clang-tidy/utils/CMakeLists.txt
clang
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
Update header guards?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68637/new/
https://reviews.llvm.org/D68637
ymandel created this revision.
ymandel added a reviewer: gribozavr.
Herald added a subscriber: mgorny.
Herald added a project: clang.
The Transformer library has been growing inside of
lib/Tooling/Refactoring. However, it's not really related to anything else in
that directory. This revision moves
