[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

This revision was automatically updated to reflect the committed changes. Closed by commit rG07c5a800dc17: Improve hover scopes for Objective-C code (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llv

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323156. dgoldman marked an inline comment as done. dgoldman added a comment. - Support protocols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-e

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323151. dgoldman added a comment. - Move over to AST.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:64 +static llvm::StringRef getNameForObjCInterface(const ObjCInterfaceDecl *ID) { + return ID ? ID->getName() : "<>"; dgoldman wrote: > sammccall

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:64 +static llvm::StringRef getNameForObjCInterface(const ObjCInterfaceDecl *ID) { + return ID ? ID->getName() : "<>"; sammccall wrote: > this function's name doesn't really describe

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323141. dgoldman marked 7 inline comments as done. dgoldman added a comment. - Address review comments Will move over to AST.cpp in next update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https:/

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry for losing this. > LMK if you think it makes sense to move some of this logic in AST.cpp > (clangd). objcContainerLocalScope seems like it would be useful to generalize > support

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. Friendly ping, I think this is still worth merging in even without the QName changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 __

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I messed around with qualified name changes - lots of things internally rely upon the qualified names so that will be best for a separate change. I could potentially handle `DocumentSymbol` fixes in here though - LMK if you think it makes sense to move some of this log

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309987. dgoldman added a comment. Add protocol test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cla

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309983. dgoldman added a comment. Swap to isa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/un

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I think there's still some more work to be done after this which might move some of this around: - DocumentSymbol support: Currently categories show up as (anonymous) or (see here