[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

2019-11-07 Thread Anders Waldenborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG86825dbe3306: [clang-format] Make '.clang-format' variants finding a loop (NFC) (authored by wanders). Changed prior to commit: https://reviews.llvm.org/D68568?vs=223488&id=228187#toc Repository: rG

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

2019-11-06 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. > But I can still land it if you think it still relevant on its own. I think the design of working through the vector of files is more elegant, especially if we want to consider looking for other files in the future. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

2019-11-06 Thread Anders Waldenborg via Phabricator via cfe-commits
wanders added a comment. In D68568#1735741 , @MyDeveloperDay wrote: > Do you need help landing this? Sorry that I havn't gotten back to this. I started looking into the "PathMatch" idea I floated in D68569 ([clang-for

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

2019-11-06 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Do you need help landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68568/new/ https://reviews.llvm.org/D68568 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

2019-10-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Thank you for the patch, I think this looks cleaner and generally LGTM, I think its always good to put a little description of the change along with the NFC in the title to let people know that functionally there isn't any change without having to work though the

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

2019-10-07 Thread Anders Waldenborg via Phabricator via cfe-commits
wanders created this revision. wanders added a reviewer: clang-format. wanders added a project: clang-format. Herald added a project: clang. No functional change intended Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68568 Files: clang/lib/Format/Format.cpp Index: clang/l