Re: [PATCH] D68535: Fix loop unrolling initialization in the new pass manager

2019-10-14 Thread Eric Christopher via cfe-commits
Thanks for the text - I didn't have anything to add or change so I just used it verbatim :) Committed thusly: Committed revision 374838. Committed f64329154c3 to svn. On Mon, Oct 7, 2019 at 9:36 AM Alina Sbirlea via Phabricator wrote: > > asbirlea added a comment. > > Maybe elaborate in the pat

[PATCH] D68535: Fix loop unrolling initialization in the new pass manager

2019-10-07 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea added a comment. Maybe elaborate in the patch description what `determine when and how we will unroll loops.` means? e.g.: "The default before and after this patch is for LoopUnroll to be enabled, and for it to use a cost model to determine whether to unroll the loop (`OnlyWhenForced

[PATCH] D68535: Fix loop unrolling initialization in the new pass manager

2019-10-05 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc accepted this revision. chandlerc added a reviewer: asbirlea. chandlerc added a comment. This revision is now accepted and ready to land. Adding Alina so she is aware of the change and can comment if she spots anything I'm missing... I think this is fine to go in as-is to fix the immed

[PATCH] D68535: Fix loop unrolling initialization in the new pass manager

2019-10-04 Thread Eric Christopher via Phabricator via cfe-commits
echristo created this revision. echristo added reviewers: chandlerc, hfinkel. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mcrosier. Herald added projects: clang, LLVM. In the new pass manager use PTO.LoopUnrolling to determine when and how we will unroll loops. Also comment a f