[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG26748a321e20: [clang-format] Add new option to add spaces around conditions Summary: This… (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D68346?vs=225345&id=231930#to

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14386 + verifyFormat("while ( a )\n return;", Spaces); + verifyFormat("while ( (a && b) )\n return;", Spaces); + verifyFormat("do {\n} while ( 1 != 0 );", Spaces); is thi

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added a comment. Can you rebase it and add a release note in docs/ReleaseNote.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___ cfe-commits

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14382 + verifyFormat("if ( !a )\n return;", Spaces); + verifyFormat("if ( a )\n return;", Spaces); + verifyFormat("if constexpr ( a )\n return;", Spaces); show "else if"

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

timwoj added a comment. Thanks for the consideration on committer access, but I'm going to have to pass for the time being. That said, can someone land this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added a comment. Thank you for the patch. If you plan to continue to submit patches I think it would be worthwhile if you applied for commit access, This is not the first revision from you and we need more people who are willing to help with clang-format to fix bug and do code r

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar accepted this revision. mitchell-stellar added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___ cfe-commits mailing list cfe

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

timwoj updated this revision to Diff 225345. timwoj added a comment. Fix ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1955 + /// \endcode + bool SpacesInConditionalStatement; + Nitpick: this

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

timwoj added a comment. In D68346#1708384 , @timwoj wrote: > Changed option name to SpacesInConditionalStatement, added > isKeywordWithCondition method, added some extra tests Sorry for the delay on getting back to this. I'm not the original author and

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

timwoj updated this revision to Diff 224890. timwoj added a comment. Changed option name to SpacesInConditionalStatement, added isKeywordWithCondition method, added some extra tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2290 +**SpacesAroundConditions** (``bool``) + If ``true``, spaces will be inserted around if/for/while (and similar) conditions. ---

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1950 + /// similar) conditions. + bool SpacesAroundConditions; + its position

[PATCH] D68346: Clang-format: Add new option to add spaces around conditions

timwoj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff adds a new option SpacesAroundConditions that inserts spaces inside the braces for conditional statements. It's used by the Zeek project (https://github.com/zeek/zeek) as described in t