Re: [PATCH] D6833: Clang-format: Braces Indent Style Whitesmith

2019-06-12 Thread JVApen via cfe-commits
Hello Tim, I am no longer working on this. I've spent my time convincing my colleagues that clang-format is useful enough to change our braces, with success. I remember also being stuck on the enumerations. Good luck! On Wed, Jun 12, 2019, 04:16 Tim Wojtulewicz via Phabricator < revi...@reviews.

[PATCH] D6833: Clang-format: Braces Indent Style Whitesmith

2019-06-11 Thread Tim Wojtulewicz via Phabricator via cfe-commits
timwoj added a comment. I updated this patch to remove all of the code from `ContinuationIndenter` and to use the newer `BraceWrapping` style option instead of setting each one individually in `UnwrappedLineParser`. I still have the same issue with enums. Looking at the `RootToken` in `Unwrapp

[PATCH] D6833: Clang-format: Braces Indent Style Whitesmith

2016-11-05 Thread Daniel Jasper via cfe-commits
djasper added a comment. In case you still want to move forward with this, some more comments. Why have you opted for doing this in getNewLineColumn instead of the UnwrappedLineFormatter::formatFirstToken() function I suggested? I think the latter would be way easier, but there might be cases I

[PATCH] D6833: Clang-format: Braces Indent Style Whitesmith

2016-10-18 Thread Sandeep Tailor via cfe-commits
insysion added a comment. Is this issue dead? I'm looking to use the tool for a Whitesmiths formatted project and would be happy to finish off the work. https://reviews.llvm.org/D6833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l