[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

2019-10-02 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL373561: [HIP] Support -emit-llvm for device compilation (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

2019-10-02 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. LGTM. Thank you for fixing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

2019-10-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 222904. yaxunl added a comment. fix -S CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D68284 Files: lib/Driver/Driver.cpp test/Driver/hip-device-compile.hip Index: test/Driver/hip-device-compile.hip ==

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

2019-10-02 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Could you also add a check for `-S` w/o `-emit-llvm`, too ? AFAICT it currently wants to produce a bundle, which is not very helpful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D68284 ___

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

2019-10-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D68284#1690554 , @tra wrote: > LGTM. > > Does it produce textual IR if used with `-S`? Now it produces textural IR if used with -S. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D6

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

2019-10-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 222826. yaxunl added a comment. Make it work for -S CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D68284 Files: lib/Driver/Driver.cpp test/Driver/hip-toolchain-emit-llvm.hip Index: test/Driver/hip-toolchain-

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

2019-10-01 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. LGTM. Does it produce textual IR if used with `-S`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D68284 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

2019-10-01 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Sometimes it is useful to compile HIP device code to LLVM BC. It is not convenient to use clang -cc1 since there are lots of options needed. This patch allows clang driver to compile HIP device code to LLVM BC with -emit-llvm -c. htt