This revision was automatically updated to reflect the committed changes.
Closed by commit rL373472: [Clangd] ExtractFunction: Don't extract body of
enclosing function. (authored by SureYeaah, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
SureYeaah updated this revision to Diff 222815.
SureYeaah marked an inline comment as done.
SureYeaah added a comment.
Added assert and removed fixme
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68245/new/
https://reviews.llvm.org/D68245
Files:
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks
Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:231
+ if (const Stmt *S = Child->ASTNode.get())
+if (EnclosingFunc->hasBody() &
SureYeaah created this revision.
SureYeaah added reviewers: sammccall, kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
This patch disable extraction of the body of the enclosing function.
`void f() [[{}]]`
Extr
