This revision was automatically updated to reflect the committed changes.
Closed by commit rL373320: [clangd] Use the index-based API to do the
header-source switch. (authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit
hokein updated this revision to Diff 222574.
hokein marked 3 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68211/new/
https://reviews.llvm.org/D68211
Files:
clang-tools-extra/cla
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
some nits, thanks!
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:456
+ // 1) use the file-only heuristic, it requires some IO but it is much
+ //faster tha
hokein updated this revision to Diff 222432.
hokein marked 4 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68211/new/
https://reviews.llvm.org/D68211
Files:
clang-tools-extra/cla
kadircet added a comment.
thanks, mostly LG
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:453
+void ClangdServer::switchSourceHeader(
+PathRef Path, Callback> CB) {
+ if (auto CorrespondingFile =
could you add some comments explaining, why we first
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
If the file heuristic fails, we try to use the index&AST to do the
header/source inference.
Repository:
rG LLVM Github
