gchatelet marked an inline comment as done.
gchatelet added inline comments.
Comment at: llvm/trunk/lib/Target/AArch64/AArch64StackTagging.cpp:65
-static constexpr unsigned kTagGranuleSize = 16;
+static const Align kTagGranuleSize = Align(16);
arichardson wro
arichardson added inline comments.
Comment at: llvm/trunk/lib/Target/AArch64/AArch64StackTagging.cpp:65
-static constexpr unsigned kTagGranuleSize = 16;
+static const Align kTagGranuleSize = Align(16);
gchatelet wrote:
> arichardson wrote:
> > Can't the Align
gchatelet marked an inline comment as done.
gchatelet added inline comments.
Comment at: llvm/trunk/lib/Target/AArch64/AArch64StackTagging.cpp:65
-static constexpr unsigned kTagGranuleSize = 16;
+static const Align kTagGranuleSize = Align(16);
arichardson wro
arichardson added inline comments.
Comment at: llvm/trunk/lib/Target/AArch64/AArch64StackTagging.cpp:65
-static constexpr unsigned kTagGranuleSize = 16;
+static const Align kTagGranuleSize = Align(16);
Can't the Align ctor be constexpr? Will this result in a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL373207: [Alignment][NFC] Remove
AllocaInst::setAlignment(unsigned) (authored by gchatelet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D68141?vs=222400&id=222409#toc
Repository:
gchatelet updated this revision to Diff 222400.
gchatelet marked an inline comment as done.
gchatelet added a comment.
Herald added a reviewer: bollu.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68141/new/
https://reviews.llvm.
gchatelet updated this revision to Diff 222372.
gchatelet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68141/new/
https://reviews.llvm.org/D68141
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/CodeGen/CGC
courbet added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64StackTagging.cpp:461
void AArch64StackTagging::alignAndPadAlloca(AllocaInfo &Info) {
- unsigned NewAlignment = std::max(Info.AI->getAlignment(), kTagGranuleSize);
+ MaybeAlign NewAlignment(std::max(Info.
gchatelet created this revision.
gchatelet added a reviewer: courbet.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, eraman,
nhaehnle, jvesely, arsenm, jholewinski.
Herald added projects: clang, LLVM.
This is patch is part of a series to introduce an Alignment type.
See this thre
