This revision was automatically updated to reflect the committed changes.
Closed by commit rL373950: Fix for expanding __pragmas in macro arguments
(authored by akhuang, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
rnk added a subscriber: Bigcheese.
rnk added a comment.
+ @Bigcheese, for amusement. We discussed some interesting behavior of _Pragma
and C++ raw string literals last night.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68114/new/
https://reviews
akhuang updated this revision to Diff 223255.
akhuang added a comment.
- move TokenCollector out of function
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68114/new/
https://reviews.llvm.org/D68114
Files:
clang/lib/Lex/Pragma.cpp
clang/test/Pr
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Nice, the solution was right in front of us the whole time. :)
lgtm, but please share the TokenCollector class.
Comment at: clang/lib/Lex/Pragma.cpp:169
struct TokenCollector
akhuang updated this revision to Diff 222464.
akhuang added a comment.
comments/whitespace/test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68114/new/
https://reviews.llvm.org/D68114
Files:
clang/lib/Lex/Pragma.cpp
clang/test/Preprocessor/pr
akhuang created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Avoid parsing __pragma into an annotation token when macro arguments are
pre-expanded.
This is what clang currently does when parsing _Pragmas.
Fixes https://bugs.llvm.org/show_bug.cgi?id=41128,
