MyDeveloperDay added a comment.
As the number of clauses is vast, I think sometimes its worth just putting a
one-line comment in to explain what construct you are matching, just to help
future maintainers
Comment at: clang/lib/Format/TokenAnnotator.cpp:1375
+}
+
// L
AndWass updated this revision to Diff 87.
AndWass added a comment.
Updated to fix test failures.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68072/new/
https://reviews.llvm.org/D68072
Files:
clang/lib/Format/TokenAnnotator.cpp
clang/unittests/Format/FormatTest.cpp
Index: cla
ilya-biryukov reopened this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
The patch breaks some tests, see
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/27891/steps/ninja%20check%201/logs/FAIL%3A%20Clang-Unit%3A%3AFormatTes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL373056: [clang-format] Reference qualifiers in member
templates causing extra… (authored by ibiryukov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior
AndWass added a comment.
@klimek I don't have commit access yet, could you please commit it for me?
Thanks
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68072/new/
https://reviews.llvm.org/D68072
___
c
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG, nice patch, thanks!
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68072/new/
https://reviews.llvm.org/D68072
_
AndWass created this revision.
AndWass added reviewers: klimek, owenpan, krasimir, timwoj.
AndWass added a project: clang-format.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The following code
struct f {
template
void bar() && noexcept {}
};
will be format
