This revision was automatically updated to reflect the committed changes.
Closed by commit rL372888: [clangd] Change constness of parameters to
findExplicitRefs (authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
@kadircet says we're using this pattern all over clangd. This somehow slipped
my view before.
LGTM to be consistent with the rest of clangd (and functions in `FindTarget.h`).
I t
ilya-biryukov added a comment.
Who are the callers? Selection tree?
FWIW, I'd rather pass non-const everywhere, the concept of const-ness is just
not very useful for AST nodes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68027/new/
https://revie
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Recursive AST requires non-const ast nodes, but it doesn't really
mutate them. In addition to that, in clangd we mo
