[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. In D67978#1684169 , @ABataev wrote: > In D67978#1684104 , @lildmh wrote: > > > In D67978#1683166 , @ABataev wrote: > > > > > In D67978#1683146

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1684104 , @lildmh wrote: > In D67978#1683166 , @ABataev wrote: > > > In D67978#1683146 , @lildmh wrote: > > > > > HI Alexey, the ast print

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh marked an inline comment as done. lildmh added a comment. In D67978#1683166 , @ABataev wrote: > In D67978#1683146 , @lildmh wrote: > > > HI Alexey, the ast print test is already there. Because I didn't check

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1683146 , @lildmh wrote: > HI Alexey, the ast print test is already there. Because I didn't check the > mapper for array type before, such code will always not report any error, and > ast print test is correct. Codegen

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh marked an inline comment as done. lildmh added a comment. HI Alexey, the ast print test is already there. Because I didn't check the mapper for array type before, such code will always not report any error, and ast print test is correct. Codegen test belongs to the other patch I released.

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. Definitely need positive tests with ast printing and codegen. Comment at: lib/Sema/SemaOpenMP.cpp:14751 +assert(Type->getAsArrayTypeUnsafe() && "Expect to get a valid array type"); +Type = Type->getAsArrayTypeUnsafe()->getElementType().getCanoni

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. In D67978#1681388 , @ABataev wrote: > In D67978#1681333 , @lildmh wrote: > > > In D67978#1681319 , @ABataev wrote: > > > > > In D67978#1681318

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1681333 , @lildmh wrote: > In D67978#1681319 , @ABataev wrote: > > > In D67978#1681318 , @lildmh wrote: > > > > > Without this patch, it ca

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. In D67978#1681319 , @ABataev wrote: > In D67978#1681318 , @lildmh wrote: > > > Without this patch, it cannot recognize array with mapper, for instance, > > `#pragma omp target map(mapper(a),

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1681318 , @lildmh wrote: > Without this patch, it cannot recognize array with mapper, for instance, > `#pragma omp target map(mapper(a),to: arr[0:2])` won't work without this > patch. What if we have a mapper for the

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. Without this patch, it cannot recognize array with mapper, for instance, `#pragma omp target map(mapper(a),to: arr[0:2])` won't work without this patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67978/new/ https://reviews.llvm.org/D67

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. What happens without this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67978/new/ https://reviews.llvm.org/D67978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh created this revision. lildmh added reviewers: ABataev, Meinersbur, hfinkel, jdoerfert. lildmh added a project: OpenMP. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This patches fixes the case when a user-defined mapper is attached to the elements of an a