This revision was automatically updated to reflect the committed changes.
ymandel marked an inline comment as done.
Closed by commit rL372936: [libTooling] Add `run` combinator to Stencils.
(authored by ymandel, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
ymandel marked 4 inline comments as done.
ymandel added a comment.
Thanks for the review!
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181
+/// This supports user-defined extensions to the Stencil language.
+StencilPart run(MatchConsumer C);
+
gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181
+/// This supports user-defined extensions to the Stencil language.
+StencilPart run(MatchConsumer
ymandel marked an inline comment as done.
ymandel added inline comments.
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181
+/// This supports user-defined extensions to the Stencil language.
+StencilPart run(MatchConsumer C);
+
gribozavr wrote:
>
gribozavr added inline comments.
Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181
+/// This supports user-defined extensions to the Stencil language.
+StencilPart run(MatchConsumer C);
+
We could reimplement all other stencils through `run()` and
ymandel updated this revision to Diff 221554.
ymandel added a comment.
clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67969/new/
https://reviews.llvm.org/D67969
Files:
clang/include/clang/Tooling/Refactoring/Stencil.h
clang/lib/Too
ymandel created this revision.
ymandel added a reviewer: gribozavr.
Herald added a project: clang.
This revision adds `run`, a StencilPart that runs a user-defined function that
computes a result over `MatchFinder::MatchResult`.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D67
