[PATCH] D67787: Add 8548 CPU definition and attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc4bc5aa0d84: Add 8548 CPU definition and attributes (authored by chmeee). Changed prior to commit: https://reviews.llvm.org/D67787?vs=228589&id=228995#toc Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 accepted this revision. vit9696 added a comment. This revision is now accepted and ready to land. Actually thanks for adding C checks too. The new revision also looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ http

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. @vit9696 mind reviewing again with the added tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787 ___ cfe-commits mailing list cfe-c

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits updated this revision to Diff 228589. jhibbits added a comment. Add clang-translation tests for e500 and 8548 CPU definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787 Files: clang/lib/Bas

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 accepted this revision. vit9696 added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787 __

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits marked an inline comment as done. jhibbits added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:61 .Case("a2q", "a2q") +.Case("8548", "e500") +.Case("e500", "e500") vit9696 wrote: > That looks like a typo t

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits updated this revision to Diff 226583. jhibbits added a comment. Don't double-check 8548 CPU for setting LLVM CPU type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787 Files: clang/lib/Basic/Targe

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 added a comment. I noticed a typo in the file, but the rest looks good now. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:61 .Case("a2q", "a2q") +.Case("8548", "e500") +.Case("e500", "e500") That looks like a typo to me.

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits updated this revision to Diff 226529. jhibbits added a comment. Make 8548 actually denote e500 LLVM target, add SPE checks to 8548 preprocessor test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. In D67787#1719251 , @vit9696 wrote: > A side note regarding SPE support. I am currently upgrading to LLVM 9.0 and I > discovered that this patch was not committed anyhow at all: > https://reviews.llvm.org/D54583#1444288 Yeah,

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 added a comment. Yes, that's the point, since 8548 is an alias. A side note regarding SPE support. I am currently upgrading to LLVM 9.0 and I discovered that this patch was not committed anyhow at all: https://reviews.llvm.org/D54583#1444288 Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. @vit9696 The only thing GCC defines for mcpu=8548 is __NO_LWSYNC__, the SPE-specific #defines are from -mspe. That said, since I explicitly do enable SPE for e500 CPU, I guess it makes sense to add it to the test. Repository: rC Clang CHANGES SINCE LAST ACTION h

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 added a comment. @jhibbits Should not the test in test/Preprocessor/init.c also ensure that `__SPE__` and `__NO_FPRS__` macros are defined with CPU 8548? The rest looks good to me, thank you. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ http

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits created this revision. jhibbits added reviewers: nemanjai, hfinkel, joerg, kthomsen. Herald added subscribers: cfe-commits, jsji, MaskRay, kbarton. Herald added a project: clang. 8548 CPU is GCC's name for the e500v2, so accept this in clang. The e500v2 doesn't support lwsync, so define

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. Herald added a subscriber: wuzish. I made 8548 an alias in clang to e500, because e500 is recognized in llvm as a CPU, so gets us the feature list and, more importantly, the instruction scheduler. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv