On Tue, Jan 7, 2020 at 3:40 PM John McCall wrote:
>
> On Tue, Jan 7, 2020 at 3:18 PM Aaron Ballman wrote:
> > It seems like GCC doesn't do good things when trying to link two
> > functions with empty asm labels but Clang does seem to do something
> > reasonable. I can't quite tell whether this is
On Tue, Jan 7, 2020 at 3:18 PM Aaron Ballman wrote:
> It seems like GCC doesn't do good things when trying to link two
> functions with empty asm labels but Clang does seem to do something
> reasonable. I can't quite tell whether this is a case for a diagnostic
> or not. Note the generated assembl
On Tue, Jan 7, 2020 at 3:13 PM John McCall wrote:
>
> On Tue, Jan 7, 2020 at 3:02 PM Aaron Ballman wrote:
> > On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits
> > wrote:
> > > On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator
> > > wrote:
> > > > Sorry to dredge up an old r
On Tue, Jan 7, 2020 at 3:02 PM Aaron Ballman wrote:
> On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits
> wrote:
> > On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator
> > wrote:
> > > Sorry to dredge up an old review, but I recently ran into a bug in this
> > > area and am n
On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits
wrote:
>
> On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator
> wrote:
> > aaron.ballman added inline comments.
> >
> >
> >
> > Comment at: cfe/trunk/lib/AST/Mangle.cpp:127
> > +// do not add a "\01" prefix.
On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator
wrote:
> aaron.ballman added inline comments.
>
>
>
> Comment at: cfe/trunk/lib/AST/Mangle.cpp:127
> +// do not add a "\01" prefix.
> +if (!ALA->getIsLiteralLabel() || ALA->getLabel().startswith("llvm.")) {
> +
aaron.ballman added inline comments.
Comment at: cfe/trunk/lib/AST/Mangle.cpp:127
+// do not add a "\01" prefix.
+if (!ALA->getIsLiteralLabel() || ALA->getLabel().startswith("llvm.")) {
+ Out << ALA->getLabel();
Sorry to dredge up an old review, but
This revision was automatically updated to reflect the committed changes.
Closed by commit rL372903: [Mangle] Add flag to asm labels to disable
'\01' prefixing (authored by vedantk, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
h
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67774/new/
https://reviews.llvm.org/D67774
___
cfe-commits mailing list
vsk updated this revision to Diff 221801.
vsk added a comment.
- Add a comment describing where non-literal labels are used.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67774/new/
https://reviews.llvm.org/D67774
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/A
teemperor resigned from this revision.
teemperor added a comment.
This LGTM modulo rjmccall's comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67774/new/
https://reviews.llvm.org/D67774
___
cfe-commits mailing list
cfe-commits@lists.l
rjmccall added a comment.
Thanks. One last and minor request: please mention in the comment on
IsLiteralLabel that non-literal labels are used by some external AST sources
like LLDB.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67774/new/
https://reviews.llvm.org/D67774
__
vsk updated this revision to Diff 221645.
vsk retitled this revision from "[Mangle] Add flag to asm labels to disable
global prefixing" to "[Mangle] Add flag to asm labels to disable '\01'
prefixing".
vsk edited the summary of this revision.
vsk added a comment.
- Address latest round of comment
13 matches
Mail list logo
