[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372753: [clangd] Add semantic selection to ClangdLSPServer. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221534. usaxena95 added a comment. Removed ununsed header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Comment at: clang-tools-extra/clangd/Protocol.cpp:18 #include "llvm/ADT/Hashing.h" +#include "llvm/ADT/STLExtras.h" #include "llvm/ADT/SmallString.h" --

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1169 +Result.emplace_back(render(std::move(*Ranges))); +return Reply(std::move(Result)); + }); hokein wrote: > does `Reply({render(std::move(*Ranges))})

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221521. usaxena95 marked 9 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tool

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein added a comment. mostly good, a few nits. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { + if (Params.positions.size() != 1) { +elog("{0} positions provided to SelectionRange. Supports exactly one " usaxena95 w

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added a comment. > The SelectionRangeClientCapabilities determines what should the LSP server > send the client, if it is true, clangd should send > SelectionRangeRegistrationOptions. > But looking at the current specification, it doesn't seem to add too much > value. I think we can

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221510. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tool

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein added a comment. In D67720#1680460 , @usaxena95 wrote: > I am not sure adding client capability is useful here. I have not used the > client capability for selectionRange anywhere and I think we can remove it. > WDYT ? The `SelectionRangeClient

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221499. usaxena95 marked 7 inline comments as done. usaxena95 added a comment. Addressed comments: Added client/server capabilities. Made lit test smaller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added a comment. I am not sure adding client capability is useful here. I have not used the client capability for selectionRange anywhere and I think we can remove it. WDYT ? Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { + if

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { + if (Params.positions.size() != 1) { +elog("{0} positions provided to SelectionRange. Supports exactly one " hokein wrote: > maybe add

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein added a comment. I think we're missing the client/server capability implementation in this patch, we should include them. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { + if (Params.positions.size() != 1) { +elog("{0} position

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1135 + Params.positions.size()); +Reply(llvm::make_error("failed to decode request", + ErrorCode::InvalidRequest)); ilya-biry

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 220710. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tool

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 220703. usaxena95 added a comment. Fixed error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

ilya-biryukov added a comment. A drive-by comment... Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1135 + Params.positions.size()); +Reply(llvm::make_error("failed to decode request", + ErrorCode::InvalidRequest));

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This adds semantic selection to the LSP Server. Adds support for serialization of input request and the o