This revision was automatically updated to reflect the committed changes.
Closed by commit rL372975: [OpenCL] Add -Wconversion to
fdeclare-opencl-builtins test (authored by svenvh, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ht
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102
// expected-error@-2{{implicit declaration of function 'get_sub_group_size' is
invalid in Open
svenvh marked an inline comment as done.
svenvh added inline comments.
Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102
// expected-error@-2{{implicit declaration of function 'get_sub_group_size' is
invalid in OpenCL}}
+// expected-error@-3{{implicit conversion
Anastasia added inline comments.
Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102
// expected-error@-2{{implicit declaration of function 'get_sub_group_size' is
invalid in OpenCL}}
+// expected-error@-3{{implicit conversion changes signedness: 'int' to 'uint'
svenvh created this revision.
svenvh added a reviewer: Anastasia.
Herald added subscribers: cfe-commits, kristina, yaxunl.
Herald added a reviewer: rengolin.
Herald added a project: clang.
Add the -Wconversion -Werror options to check no unexpected conversion
is done.
Patch by Pierre Gondois and