[PATCH] D67650: [clangd] Add SemanticRanges to Clangd server.

2019-09-17 Thread UTKARSH SAXENA via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372102: Add SemanticRanges to Clangd server. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D67650: [clangd] Add SemanticRanges to Clangd server.

2019-09-17 Thread UTKARSH SAXENA via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 220465. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67650/new/ https://reviews.llvm.org/D67650 Files: clang-tool

[PATCH] D67650: [clangd] Add SemanticRanges to Clangd server.

2019-09-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! looks good. I think next step is to implement it in the LSP layer. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:161 + )cpp"; + Annotati