[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver abandoned this revision. zoecarver added a comment. Closing in favor of D67052 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67588/new/ https://reviews.llvm.org/D67588 ___ cfe-commits mailing lis

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

EricWF added a comment. LGTM other than the inline comments. I'll take a second pass at this once they're addressed. Let's land the patch this week! Comment at: clang/include/clang/Sema/DeclSpec.h:419 static bool isTypeRep(TST T) { return (T == TST_typename || T == TST

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver added a comment. @lebedev.ri after adding _only_ these builtins to libc++ the type trait tests run several seconds faster. I think if we update _all_ the type traits to use builtins then, it could increase speed of the type trait tests by as much as 50% (if not more). CHANGES SINCE

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

lebedev.ri added a comment. > The `__remove_cv` test sees a 160% build time imporvement while the > `__add_cv` test sees an 8% improvement. Those numbers are specifically for those macrobenchmarks, right? What impact does this have on some real-world code? I'm just curious as to cost/benefit her

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver updated this revision to Diff 220227. zoecarver added a comment. Generate diff based on D67052 (arc wasn't working so I had to do it manually this time). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67588/new/ https://reviews.llvm.org/D67588

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver created this revision. zoecarver added reviewers: EricWF, eli.friedman, rsmith, craig.topper, mclow.lists. zoecarver added projects: clang, libc++. zoecarver updated this revision to Diff 220226. zoecarver added a comment. - diff from D67052 , not master

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver updated this revision to Diff 220226. zoecarver added a comment. - diff from D67052 , not master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67588/new/ https://reviews.llvm.org/D67588 Files: clang/inc