thakis added inline comments.
Comment at: cfe/trunk/lib/Driver/ToolChains/Clang.cpp:6076
+
+ return Args.MakeArgString(std::string(getBaseInputStem(Args, Inputs)) +
".d");
}
Can you use llvm::Twine() instead of std::string() here?
Repository:
rL LLVM
CHAN
This revision was automatically updated to reflect the committed changes.
Closed by commit rL371853: Fix depfile name construction (authored by
LukeCheeseman, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
chill accepted this revision.
chill added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67542/new/
https://reviews.llvm.org/D67542
___
cfe-commits mailing list
cfe-commits@lis
LukeCheeseman updated this revision to Diff 220067.
LukeCheeseman added a comment.
- Add a requires shell
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67542/new/
https://reviews.llvm.org/D67542
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/metadata-with-dots.c
I
chill added a reviewer: chill.
chill added inline comments.
Comment at: clang/test/Driver/metadata-with-dots.c:2
+// RUN: mkdir -p out.dir
+// RUN: cat %s > out.dir/test.c
+// RUN: %clang -E -MMD %s -o out.dir/test
Is this going to ruin on Windows ?
==
