[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:193 + if (scopes[0] == "meta.disabled") { +this.inactiveDecorationIndex = index; +return vscode.win

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge updated this revision to Diff 247077. nridge added a comment. Update to use 'clangd.preprocessor.inactive' as the scope name for inactive lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537 Files:

[PATCH] D67537: [clangd] Client-side support for inactive regions

hokein added a comment. > Do you mean naming the scope something like `clangd.meta.disable` to make it > clear it's a clangd extension? > > (In that case, we might as well make it something more descriptive, like > `clangd.preprocessor.inactive`. `meta` doesn't convey much information.) yes, t

[PATCH] D67537: [clangd] Client-side support for inactive regions

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62144 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge updated this revision to Diff 240026. nridge marked an inline comment as done. nridge added a comment. Inject the inactive code decoration type into Highligher.decorationTypes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge added a comment. In D67537#1833987 , @hokein wrote: > there is some significant progress about semantic highlighting on VSCode, > VSCode now provides an experimental semantic token API >

[PATCH] D67537: [clangd] Client-side support for inactive regions

hokein added a comment. sorry for the looong delay, I was OOO for a few weeks before. The patch looks fine, my concern is that how do we support this `line` extension when LSP provides a standard implementation -- there is some significant progress about semantic highlighting on VSCode, VSCode

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge added reviewers: kadircet, ilya-biryukov, sammccall. nridge added a comment. Review ping again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537 ___ cfe

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:210 + isWholeLine: true, + // FIXME: Avoid hardcoding these colors. + light: { I'm open

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge updated this revision to Diff 230586. nridge added a comment. Clean up patch a bit and update tests as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537 Files: clang-tools-extra/clangd/clients/c