This revision was automatically updated to reflect the committed changes.
Closed by commit rL372725: [clangd] Collect macros in the preamble region of
the main file (authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
hokein updated this revision to Diff 221504.
hokein added a comment.
update header guard.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67496/new/
https://reviews.llvm.org/D67496
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-ext
hokein updated this revision to Diff 221501.
hokein marked 10 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67496/new/
https://reviews.llvm.org/D67496
Files:
clang-tools-e
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
A ton of small NITs too, but they're all small details.
Comment at: clang-tools-extra/clangd/Macro.h:1
+//===--- Macro.h
hokein added inline comments.
Comment at: clang-tools-extra/clangd/Macro.h:67
+ bool InMainFile = true;
+ std::vector &MainFileMacros;
+};
ilya-biryukov wrote:
> hokein wrote:
> > ilya-biryukov wrote:
> > > Could we model in a way that avoids duplicating macro
hokein updated this revision to Diff 221492.
hokein marked 2 inline comments as done.
hokein added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67496/new/
https://reviews.llvm.org/D67496
Files:
clang-tools-extra/cla
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/Macro.h:59
+
+if (auto Range = getTokenRange(SM, LangOpts, MacroNameTok.getLocation())) {
+ MainFileMacros.push_back(
hokein wrote:
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/Macro.h:59
+
+if (auto Range = getTokenRange(SM, LangOpts, MacroNameTok.getLocation())) {
+ MainFileMacros.push_back(
ilya-biryukov wrote:
> Conve
ilya-biryukov added a comment.
Sorry for the delay
Comment at: clang-tools-extra/clangd/Macro.h:59
+
+if (auto Range = getTokenRange(SM, LangOpts, MacroNameTok.getLocation())) {
+ MainFileMacros.push_back(
Converting here is too early, could we keep th
hokein added a comment.
Herald added a subscriber: usaxena95.
friendly ping, in case you missing it :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67496/new/
https://reviews.llvm.org/D67496
___
cfe-c
hokein updated this revision to Diff 219904.
hokein added a comment.
some cleanup
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67496/new/
https://reviews.llvm.org/D67496
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/clang
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay.
Herald added a project: clang.
- store all macro references in the ParsedAST, which also helps to implement
find references for macros.
- unify the two var
12 matches
Mail list logo
