[PATCH] D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker.

2019-09-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Btw, `evalCall` is not deprecated. In fact, there are no alternatives for it in many cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67480/new/ https://reviews.llvm.org/D67480 __

[PATCH] D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker.

2019-09-18 Thread Balázs Kéri via Phabricator via cfe-commits
balazske abandoned this revision. balazske added a comment. I try to improve `StreamChecker` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67480/new/ https://reviews.llvm.org/D67480 ___ cfe-co

[PATCH] D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker.

2019-09-13 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. Code of StreamChecker does not look much better, it uses deprecated `eval::Call` and does not check for escape. But it handles more functions and error at open (still not `freopen`). A mixture of both would be a better option. Repository: rG LLVM Github Monorepo CH

[PATCH] D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker.

2019-09-12 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. `SimpleStreamChecker` is a historical tutorial example , i don't think we should be updating it other than for modernizing checker API use. It was supposed to handle a few simple examples correctly but it wasn't supposed to suppo