[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

2019-09-12 Thread Nick Desaulniers via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371766: [Clang][CodeGen] support alias attribute w/ gnu_inline (authored by nickdesaulniers, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

2019-09-11 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 219790. nickdesaulniers added a comment. - adjust parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67455/new/ https://reviews.llvm.org/D67455 Files: clang/lib/AST/Decl.cpp clang/test/CodeGen/al

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

2019-09-11 Thread Andrew Kelley via Phabricator via cfe-commits
andrewrk requested changes to this revision. andrewrk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/AST/Decl.cpp:3352 + assert((doesThisDeclarationHaveABody() || willHaveBody()) || + hasAttr() && "Must be a function definitio

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

2019-09-11 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added reviewers: aaron.ballman, rsmith, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. r369705 did not consider the addition of gnu_inline on function declarations of alias attributed functions. This resulte