[PATCH] D67436: CodeGen: set correct result for atomic compound expressions

2019-11-07 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover closed this revision. t.p.northover added a comment. Thanks JF. To github.com:llvm/llvm-project.git 0ec6a4882ee..10e0d64337d master -> master > Separately, does this do floating-point add / sub properly? We added them too > C++20. It looks like that already works because it d

[PATCH] D67436: CodeGen: set correct result for atomic compound expressions

2019-09-27 Thread JF Bastien via Phabricator via cfe-commits
jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. Separately, does this do floating-point add / sub properly? We added them too C++20. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D67436: CodeGen: set correct result for atomic compound expressions

2019-09-27 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67436/new/ https://reviews.llvm.org/D67436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D67436: CodeGen: set correct result for atomic compound expressions

2019-09-11 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover created this revision. Herald added subscribers: jfb, mcrosier. Herald added a project: clang. Atomic compound expressions try to use atomicrmw if possible, but this path doesn't set the `Result` variable, leaving it to crash in later code if anything ever tries to use the result o