[PATCH] D67429: Improve code generation for thread_local variables:

2021-08-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. https://reviews.llvm.org/D108680 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D67429: Improve code generation for thread_local variables:

2021-08-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D67429#2961873 , @rjmccall wrote: > @rsmith, can you fix or revert? Sorry for the long delay here. Looking now. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/

[PATCH] D67429: Improve code generation for thread_local variables:

2021-08-23 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. @rsmith, can you fix or revert? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D67429: Improve code generation for thread_local variables:

2021-07-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D67429#2566099 , @wolfgangp wrote: > Ping. Just wondering if there are any new insights on the issue reported in > PR48030 . I confirm that https://bugs.llvm.org/show_bug.cgi?id=480

[PATCH] D67429: Improve code generation for thread_local variables:

2021-02-16 Thread Wolfgang Pieb via Phabricator via cfe-commits
wolfgangp added a comment. Ping. Just wondering if there are any new insights on the issue reported in PR48030 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429 ___

[PATCH] D67429: Improve code generation for thread_local variables:

2020-12-08 Thread Warren Ristow via Phabricator via cfe-commits
wristow added a comment. This commit appears to be the root cause of a run-time crash related to the interaction of global initializers and the wrapper functions to access `thread_local` variables -- reported as PR48030 . Repository: rL LLVM CHA

[PATCH] D67429: Improve code generation for thread_local variables:

2019-09-12 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371767: Improve code generation for thread_local variables: (authored by rsmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D67429: Improve code generation for thread_local variables:

2019-09-11 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429 ___ cfe-commi

[PATCH] D67429: Improve code generation for thread_local variables:

2019-09-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a reviewer: jdoerfert. Herald added a project: clang. - Don't bother using a thread wrapper when the variable is known to have constant initialization. - Emit the thread wrapper as discardable-if-unused in TUs that don'