[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

Szelethus added a comment. Herald added subscribers: ASDenysPetrov, martong. Aren't `StackHint`s basically ancient `NoteTag`s? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67381/new/ https://reviews.llvm.org/D67381 _

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371658: [analyzer] NFC: Re-implement stack hints as a side map in BugReport. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

NoQ marked 2 inline comments as done. NoQ added a comment. In D67381#1665930 , @Szelethus wrote: > Side note, now that you had to work with the freshly rewritten file, do you > have any feedback on it? Dunno, i'm a very functional / pure / stateless per

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp:34 #include "clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h" -#include "clang/StaticAnalyzer/Core/PathSensitive/SVals.h" #include "llvm/ADT/Arr

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. > I'm open to discuss a better design here. Eg., i thought about making it part > of the visitor interface instead, but i don't immediately see how to do this > without breaking the logi

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Stack hints are attached to `PathDiagn