[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rL372008: [clangd] Simplify semantic highlighting visitor (authored by ibiryukov, committed by ). Herald added subscribers: llvm-commits, usaxena95. Herald added a project: LLVM. Changed prior to commit:

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov added a comment. @hokein, do you want to do another round or is this good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67341/new/ https://reviews.llvm.org/D67341 ___ cfe-commits m

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:169 private: - void addTokenForTypedef(SourceLocation Loc, const TypedefNameDecl *TD) { -auto *TSI = TD->getTypeSourceInfo(); -if (!TSI) - return; -// Try to high

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov updated this revision to Diff 219503. ilya-biryukov marked 6 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67341/new/ https://reviews.llvm.org/D67341 Files:

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

hokein added a comment. thanks, looks good, just a few nits. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:34 +return true; + if (!Name.isIdentifier()) +return false; nit: I think the check is redundant, getAsIdentifierInfo() will retur

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov added a comment. In D67341#1663104 , @hokein wrote: > Unfortunately, the patch is a bit large, containing refactoring changes and > functionality changes, is it possible to split it into (two) smaller patches? Done. There should be no func

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov updated this revision to Diff 219363. ilya-biryukov added a comment. - Turn into NFC, do not highlight lambdas differently Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67341/new/ https://reviews.llvm.org/D67341 Files: clang-tools-

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

hokein added a comment. Thanks! Unfortunately, the patch is a bit large, containing refactoring changes and functionality changes, is it possible to split it into (two) smaller patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67341/new/ htt

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. - Functions to compute highlighting kinds for things are separated from the ones that add highlighting tokens. This keeps eac