[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

This revision was automatically updated to reflect the committed changes. Closed by commit rL371504: [clangd] Collect location of macro definition in the ParsedAST (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

hokein updated this revision to Diff 219501. hokein marked an inline comment as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67264/new/ https://reviews.llvm.org/D67264 Files: clang-tools-extra/clan

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

hokein added a comment. In D67264#1663285 , @ilya-biryukov wrote: > LGTM. > > We should probably also take a look at highlighting macros inside the > preamble part of the main file. > @hokein, are you planning to do this or should we just file a bug for

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. We should probably also take a look at highlighting macros inside the preamble part of the main file. @hokein, are you planning to do this or should we just file a bug for

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

hokein added a comment. Thanks for the suggestions on the new names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67264/new/ https://reviews.llvm.org/D67264 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

hokein updated this revision to Diff 219343. hokein marked 4 inline comments as done. hokein added a comment. Rename all things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67264/new/ https://reviews.llvm.org/D67264 Files: clang-tools-extra/cl

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:104 // *definitions* in the preamble region of the main file). class CollectMainFileMacroExpansions : public PPCallbacks { const SourceManager &SM; hokein wrote: > The na

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

hokein created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. hokein retitled this revision from "[clangd] Collect location of macro definition in the ParsedAST allows semantic hightlighting macro definiti

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

hokein updated this revision to Diff 219067. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67264/new/ https://reviews.llvm.org/D67264 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/ParsedA

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:104 // *definitions* in the preamble region of the main file). class CollectMainFileMacroExpansions : public PPCallbacks { const SourceManager &SM; -