This revision was automatically updated to reflect the committed changes.
Closed by commit rG92aa0c2dbcb7: [cfi] Add flag to always generate .debug_frame
(authored by dcandler).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67216/new/
https://review
ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67216/new/
https://reviews.llvm.org/D67216
___
cfe-commits mailing list
cfe-com
dcandler updated this revision to Diff 226147.
dcandler added a comment.
Updated with the new name for the option.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67216/new/
https://reviews.llvm.org/D67216
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver
dcandler added a comment.
I think `-f[no-]force-dwarf-frame` suitably describes the behavior, and looks
in line with other options. I'll update the patch shortly unless anyone else
has any other input.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67216/new/
https://reviews.llvm.org/D
ostannard added a comment.
How about `-f[no-]force-dwarf-frame`, which I think matches the spelling and
behaviour of the existing `-fforce-enable-int128` and `-fforce-emit-vtables`
options?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67216/new/
https://reviews.llvm.org/D67216
___
dcandler added a comment.
I added the negative option more as a way to disable the flag, since I'm
currently looking at cases where it may want to be turned on by default (and a
negative option would then allow you to only get .eh_frame in cases where you'd
get both .debug_frame/.eh_frame).
Th
ostannard added a comment.
I don't like the idea of adding a `-gno-dwarf-frame` option which doesn't
always disable emission of `.debug_frame`. Since it doesn't make sense to emit
other debug info without `.debug_frame`, maybe we should just not have a
negative option?
CHANGES SINCE LAST ACTI
dcandler added a comment.
Ping?
I already spotted the line in CommandFlags.inc needs formatting with a couple
of breaks. Also the help text in Options.td could be clearer. In particular,
-gno-dwarf-frame shouldn't suggest .debug_frame won't be generated at all
(since -g might still emit it). I
dcandler updated this revision to Diff 224581.
dcandler retitled this revision from "[cfi] Add flag to always generate call
frame information" to "[cfi] Add flag to always generate .debug_frame".
dcandler edited the summary of this revision.
dcandler added reviewers: rengolin, joerg.
dcandler adde
