[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

This revision was automatically updated to reflect the committed changes. baloghadamsoftware marked an inline comment as done. Closed by commit rG0f88caeef8f2: [Analyzer] Checker for Debugging Iterator Checkers (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This is amazing, thanks!! LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67156/new/ https://reviews.llvm.org/D67156 ___ cfe-c

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

baloghadamsoftware marked 6 inline comments as done. baloghadamsoftware added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:1328-1337 +def ContainerInspectionChecker : Checker<"ContainerInspection">, + HelpText<"Check the analyzer's understanding

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

baloghadamsoftware updated this revision to Diff 222984. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67156/new/ https://reviews.llvm.org/D67156 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Stat

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

NoQ added a comment. In D67156#1661881 , @Szelethus wrote: > I'm sadly not knowledgeable enough with `CallDescriptionMap` D62557 contains a basic example. Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

Szelethus added a comment. I'm sadly not knowledgeable enough with `CallDescriptionMap`, so let's have another round of review on this, otherwise, its perfect. We talked about dividing this checker into multiple files, which would also make reviewing a bit easier. With that done, combined with

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:1328-1337 +def ContainerInspectionChecker : Checker<"ContainerInspection">, + HelpText<"Check the analyzer's understanding of C++ containers">, + Dependencies<[IteratorModeling]>, + Docume

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

NoQ added a comment. Yup, thanks, this is really nice! Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:243-244 + Getter get) const; + void analyzerContainerBegin(const CallExpr *CE, CheckerContext &C) const; + void analyzerContaine

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

Szelethus added a comment. Nice! Thank you so much for sorting this out! I think this will make reviewing far more accessible for newcomers to the IteratorChecker family. I have a couple nits to comment on, but I won't clutter the code just yet. @NoQ, do you have any high level objections t

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

baloghadamsoftware added a comment. I did not add debug calls to the tests of the existing iterator checkers yet, they will come in the next patch. After that I think the next step is to refactor the monolithic checker class into smaller ones: the iterator modelling into one file, and all the o

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. For white-box testing correct container and iterator mo