[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-09 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371390: [clangd] Update clangd-vscode docs to be more user-focused. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 218444. sammccall added a comment. Fix mailing list link again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092 Files: clang-tools-extra/clangd/clients/clangd-vscode

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 218438. sammccall marked an inline comment as done. sammccall added a comment. move images into doc-assets/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092 Files: c

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:9 + - include management + - code formatting sammccall wrote: > kadircet wrote: > > what about code-actions(and also some screenshots) > Added a section for ref

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:5 -## Usage + - code completion + - compile errors and warnings kadircet wrote: > can we also have links to section

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:95 + - use raw strings + - rerame (bound to ``, rather than a contextual code action) + s/rerame/rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. could we move the png files to a separate directory like `clangd/clients/clangd-vscode/assets`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092 ___

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 218437. sammccall added a comment. mention rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092 Files: clang-tools-extra/clangd/clients/clangd-vscode/DEVELOPING.m

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 218436. sammccall added a comment. describe refactoring features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67092/new/ https://reviews.llvm.org/D67092 Files: clang-tools-extra/clangd/clients/clangd-vsco

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on this! Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:5 -## Usage + - code completion + - compile errors and warnings -

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

2019-09-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: hokein, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Relegate "updating the extension" docs to a separate file. Repository: rG LLVM Github Monorepo https: