This revision was automatically updated to reflect the committed changes.
Closed by commit rL371719: [clang-format] Add new style option IndentGotoLabels
(authored by paulhoad, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:
tetsuo-cpp added a comment.
@MyDeveloperDay
Thanks for your suggestions! I think it's better now.
This is my first LLVM patch (hopefully first of many) so I don't have commit
permissions yet. If you're still happy with this change, could you please
commit on my behalf?
Repository:
rC Clang
tetsuo-cpp updated this revision to Diff 219582.
tetsuo-cpp added a comment.
Addressed review comments.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67037/new/
https://reviews.llvm.org/D67037
Files:
clang/docs/ClangFormatStyleOptions.rst
clang/include/clang
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
This LGTM, just some minor Nits
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1354
Line->Tokens.begin()->Tok->MustBreakBefore = true;
-
tetsuo-cpp added a comment.
Friendly ping. Could I please get this looked at?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67037/new/
https://reviews.llvm.org/D67037
___
cfe-commits mailing list
cfe-commits@lists.ll
tetsuo-cpp created this revision.
tetsuo-cpp added a reviewer: klimek.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This option determines whether goto labels are indented according to scope.
Setting this option to false causes goto labels to be flushed to the left.
This
