[PATCH] D66995: [clangd] Add highlighting for macro expansions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370482: [clangd] Add highlighting for macro expansions. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM from my side. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:471 + case HighlightingKind::Macro: +return "entity.name.function.preprocessor.expansion

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom updated this revision to Diff 218089. jvikstrom added a comment. Renamed MacroExpansion to Macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 Files: clang-tools-extra/clangd/SemanticHighligh

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + case HighlightingKind::MacroExpansion: +return "entity.name.function.preprocessor.expansion.cpp"; case HighlightingKind::NumKinds: ilya-biryukov wrote: >

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom updated this revision to Diff 218087. jvikstrom marked 3 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 Files: clang-tools-

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + case HighlightingKind::MacroExpansion: +return "entity.name.function.preprocessor.expansion.cpp"; case HighlightingKind::NumKinds: ilya-biryukov wrote: > Is

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:35 +TraverseAST(AST.getASTContext()); +// Add highlightings for Macro Expansions as they are not traversed by the +// visitor. NIT: uncapitalize and use

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom updated this revision to Diff 218061. jvikstrom added a comment. Removed SourceManager field from HighlightingTokenCollector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 Files: clang-tools-e

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. https://github.com/clangd/clangd/issues/134 Repository: rG LLVM Github Monorepo https://reviews.llvm.o