[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein closed this revision. hokein added a comment. committed in rL370760 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66945/new/ https://reviews.llvm.org/D66945 _

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein updated this revision to Diff 218450. hokein marked 3 inline comments as done. hokein added a comment. Update the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66945/new/ https://reviews.llvm.org/D66945 Files: clang-tools-extra/c

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:105 } // Mark using declarations as used by setting FoundDecls' value to zero. As // the AST is walked in order, usages are only marked after a the grib

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:105 } // Mark using declarations as used by setting FoundDecls' value to zero. As // the AST is walked in order, usages are only marked after a the P

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein updated this revision to Diff 218423. hokein added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66945/new/ https://reviews.llvm.org/D66945 Files: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp clang-to

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein updated this revision to Diff 218422. hokein marked an inline comment as done. hokein added a comment. Use a matcher to catch all template arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66945/new/ https://reviews.llvm.org/D66945 Fi

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

gribozavr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/misc-unused-using-decls.cpp:214 +class Bar {}; +Bar *bar; It is very unclear what this test does, if I didn't know about this bug. Could you add a comment? Repository: rG LLVM Git

[PATCH] D66945: [clang-tidy] Fix a false positive in unused-using-decl check.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. The previous matcher "hasAnyTemplateArgument(templateArgument())" only matches the first template argument, but the check wants to iterate all template arguments.