This revision was automatically updated to reflect the committed changes.
Closed by commit rL370457: [ASTImporter] Propagate errors during import of
overridden methods. (authored by balazske, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to c
balazske updated this revision to Diff 218039.
balazske added a comment.
- Renamed ImportOverrides, additional check in test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66933/new/
https://reviews.llvm.org/D66933
Files:
clang/lib/AST/ASTImport
shafik accepted this revision.
shafik added a comment.
LGTM but I agree w/ Gabor's comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66933/new/
https://reviews.llvm.org/D66933
___
cfe-commits mail
martong accepted this revision.
martong added a reviewer: a_sidorin.
martong added a comment.
This revision is now accepted and ready to land.
LGTM, other than a few comments.
Comment at: clang/lib/AST/ASTImporter.cpp:7809
-void ASTNodeImporter::ImportOverrides(CXXMethodDecl
balazske created this revision.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp.
Herald added a reviewer: martong.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: clang.
If importing overridden methods fails for a method it can be se
