[PATCH] D66881: [clangd][vscode] Don't leak the resources

This revision was automatically updated to reflect the committed changes. Closed by commit rL370218: [clangd][vscode] Don't leak the resources (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D66881: [clangd][vscode] Don't leak the resources

hokein updated this revision to Diff 217657. hokein added a comment. dispose the semanticHighlighting feature as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66881/new/ https://reviews.llvm.org/D66881 Files: clang-tools-extra/clangd/clien

[PATCH] D66881: [clangd][vscode] Don't leak the resources

hokein added a comment. In D66881#1649044 , @jvikstrom wrote: > Oh, was not aware we needed to dispose the extension as well. > > I think you should probably add the SemanticHighlightingFeature to the > context.subscriptions as well, right? (because I did

[PATCH] D66881: [clangd][vscode] Don't leak the resources

jvikstrom added a comment. Oh, was not aware we needed to dispose the extension as well. I think you should probably add the SemanticHighlightingFeature to the context.subscriptions as well, right? (because I didn't when I did the cleanup patch for it, sorry) Repository: rG LLVM Github Mono

[PATCH] D66881: [clangd][vscode] Don't leak the resources

hokein created this revision. hokein added a reviewer: jvikstrom. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We miss a few places where we need to add them to the subscriptions. Repository: rG LLVM Github Monorepo https://revi