[PATCH] D66806: [LifetimeAnalysis] Fix some false positives

2019-09-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL370773: [LifetimeAnalysis] Fix some false positives (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D66806: [LifetimeAnalysis] Fix some false positives

2019-09-02 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Looks like a reasonable way to suppress some false positives. It will suppress some true positives (e.g., imagine an "identity" function that returns the same pointer as was provided to

[PATCH] D66806: [LifetimeAnalysis] Fix some false positives

2019-08-27 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre added a comment. Nice! Having no false-positives is most important because this is enabled by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66806/new/ https://reviews.llvm.org/D66806 _

[PATCH] D66806: [LifetimeAnalysis] Fix some false positives

2019-08-27 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: gribozavr, mgehre. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. We should never track if a gsl::Pointer is created from an unannotated type. For example the code below is d