dexonsmith abandoned this revision.
dexonsmith added a comment.
I finished reimplementing this patch mostly as discussed, culminating in
https://reviews.llvm.org/D89431. I've rebased https://reviews.llvm.org/D89431
on top of that. Abandoning this revision.
CHANGES SINCE LAST ACTION
https://r
dexonsmith planned changes to this revision.
dexonsmith added a comment.
I'm going to change my approach here to be less error-prone. The real goal is
changing from `MemoryBuffer*` to `MemoryBufferRef`. I was adding `Optional<>`
as a cleanup but that's really a nice-to-have, which is better land
dexonsmith added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:459
Position P) {
- llvm::StringRef Code = SM.getBuffer(SM.getMainFileID())->getBuffer();
+ llvm::StringRef Code = SM.getBufferOrFake(S
arphaman added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:459
Position P) {
- llvm::StringRef Code = SM.getBuffer(SM.getMainFileID())->getBuffer();
+ llvm::StringRef Code = SM.getBufferOrFake(SM.
dexonsmith updated this revision to Diff 297245.
dexonsmith added a comment.
Rebased (on top of https://reviews.llvm.org/D89136).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66782/new/
https://reviews.llvm.org/D66782
Files:
clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.c
shafik added a comment.
`ASTImporter` changes looks good.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66782/new/
https://reviews.llvm.org/D66782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
dexonsmith added a comment.
Herald added a subscriber: usaxena95.
ping: Besides rebasing, any concerns here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66782/new/
https://reviews.llvm.org/D66782
___
cfe-commits mailing list
cfe-commits@lis
dexonsmith created this revision.
dexonsmith added reviewers: arphaman, Bigcheese, rsmith.
Herald added subscribers: llvm-commits, ributzka, kadircet, jkorous, hiraditya.
Herald added a reviewer: martong.
Herald added a reviewer: shafik.
Herald added a project: LLVM.
Change the APIs in SourceManag
